feat: add llm for post translation feature#67
Merged
Merged
Conversation
(cherry picked from commit 1afc52d53a2127eec17124f40575c99aaf112b60)
|
🚅 Deployed to the nodebb-spring-26-clean-cod-pr-67 environment in Clean Code Team (nodebb)
|
yuriiShmal
approved these changes
Mar 26, 2026
yuriiShmal
left a comment
yuriiShmal
left a comment
There was a problem hiding this comment.
One more question: why no changes to the [test/api.js] (see test/api.js)
Other than that, this UI implementation works (and matches the provided code line by line).
|
|
||
|
|
||
|
|
||
| translatorApi.translate = async function (postData) { |
There was a problem hiding this comment.
You got the backend working? Above and beyond, I see.
Author
There was a problem hiding this comment.
had to run ollama serve before starting the translation python service
Author
changing the yaml files is enough to accomodate the new fields added to the backend response, pretty sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picks the provided commit
LLM endpoint here: http://17313-team11.s3d.cmu.edu:5000/
this is PR #67 ahahaha