feat: display translation button on all posts regardless of language#108
Merged
Conversation
- Removed conditional check for isEnglish flag - Translation button now appears on both English and non-English posts - Added @fontsource-utils/scss dependency to fix CSS build issues
Pull Request Test Coverage Report for Build 19381932022Details
💛 - Coveralls |
|
Code was pulled on local machine/VM and worked as expected. Should ideally have more commits, but our team worked on multiple branches and multiple rounds of debugging, so minimal commits here. Small error in the test controller with an unchecked loop, but nothing code breaking. good work jerry! I know the team worked through a lot to get this running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Name of PR:
Update Translation Button Logic
1. Issue
Issue Summary:
The translation button only appeared on non-English posts, even though posts detected as English still needed translation availability for evaluation.
2. Changes
What changes did you make to resolve the issue?
isEnglishflag checkDoes your change introduce new dependencies to this project? If so, list here.
N/A
3. Validation
How did you trigger the change to show that it is working?
Attach screenshot(s) of the logs and UI demonstrating the change.