Skip to content

qlty smells refactoring: High complexity count (src/user/profile.js) changePassword #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zheng05jess wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qlty smells refactoring: High complexity count (src/user/profile.js) changePassword #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/user/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,11 +362,10 @@

if (isSelf && hasPassword) {
const correct = await User.isPasswordCorrect(data.uid, data.currentPassword, data.ip);
if (!correct) {
throw new Error('[[user:change-password-error-wrong-current]]');
}
if (data.currentPassword === data.newPassword) {
throw new Error('[[user:change-password-error-same-password]]');
if (!correct || data.currentPassword === data.newPassword) {
throw new Error(!correct
? '[[user:change-password-error-wrong-current]]'

Check failure on line 367 in src/user/profile.js

View workflow job for this annotation

GitHub Actions / test 

'?' should be placed at the end of the line
: '[[user:change-password-error-same-password]]');

Check failure on line 368 in src/user/profile.js

View workflow job for this annotation

GitHub Actions / test 

':' should be placed at the end of the line
}
}

Expand Down
Loading