Skip to content

Fixed code smell in src/posts/topics.js: Function with many parameters (count = 5): getPostsFromSet #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pskodr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed code smell in src/posts/topics.js: Function with many parameters (count = 5): getPostsFromSet #327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55e9358
task-1a
pskodr Mar 12, 2026
d70ac09
task-1b
pskodr Mar 12, 2026
e8e1ed3
task-1c, after review changes
pskodr Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/posts/topics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const user = require('../user');
const utils = require('../utils');

module.exports = function (Posts) {
Posts.getPostsFromSet = async function (set, start, stop, uid, reverse) {
Posts.getPostsFromSet = async function ({ set, start, stop, uid, reverse = false }) {
const pids = await Posts.getPidsFromSet(set, start, stop, reverse);
const posts = await Posts.getPostsByPids(pids, uid);
return await user.blocks.filter(uid, posts);
Comment on lines +9 to 12

Copilot AI Mar 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing Posts.getPostsFromSet from positional args to a destructured options object is a breaking API change for any external consumers (e.g. plugins importing src/posts). It can also fail silently if a caller still passes the old (set, start, stop, uid, reverse) signature, because destructuring will yield undefined for set/start/... and then query the wrong sorted set. Consider keeping backwards compatibility by accepting both calling conventions (detect object vs non-object), or introducing a new method name for the options-object signature and leaving the existing one intact (with a deprecation path).

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -44,8 +44,8 @@ module.exports = function (Posts) {
const postIndex = utils.isNumber(indices[index]) ? parseInt(indices[index], 10) + 1 : null;

if (slug && postIndex) {
const index = postIndex === 1 ? '' : `/${postIndex}`;
return `/topic/${slug}${index}`;
const postIndexSuffix = postIndex === 1 ? '' : `/${postIndex}`;
return `/topic/${slug}${postIndexSuffix}`;
}
return null;
});
Expand Down
Loading