Refactor auth route registration complexity#324
Open
sandervonk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the authentication route setup to address the qlty smell for high function complexity in
reloadRoutes.Problem
The function
reloadRoutesin src/routes/authentication.js had high cyclomatic complexity due to deeply nested strategy registration and callback handlers.What Changed
reloadRoutesto orchestration logic while preserving existing behavior.Why This Helps
reloadRoutesand improves maintainability.Validation
npm run test4650 passing,146 pendingNotes