Skip to content

created change for code smell with context #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendayyu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

created change for code smell with context #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91e13a
created change for code smell based on chatgpt
brendayyu Mar 12, 2026
4ce99ac
made changes based on claude copilot
brendayyu Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 54 additions & 36 deletions test/messaging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,37 @@

let chatMessageDelay;

const callv3API = async (method, path, body, user) => {
// helper for calling the v3 API; accepting either an options object or
// the original parameter list. this keeps the signature clean while
// still supporting existing call sites across the large test file.
const callv3API = async (methodOrOptions, path, body, user) => {
let method;
let urlPath;
let payload = {};
let uid;

if (typeof methodOrOptions === 'object' && methodOrOptions !== null && !Array.isArray(methodOrOptions)) {
({ method, path: urlPath, body: payload = {}, user: uid } = methodOrOptions);
} else {
// legacy style: callv3API(method, path, body, user)
method = methodOrOptions;
urlPath = path;
payload = body || {};
uid = user;
}

const options = {
body,
jar: mocks.users[user].jar,
body: payload,
jar: mocks.users[uid].jar,
};

if (method !== 'get') {
options.headers = {
'x-csrf-token': mocks.users[user].csrf,
'x-csrf-token': mocks.users[uid].csrf,
};
}

return request[method](`${nconf.get('url')}/api/v3${path}`, options);
return request[method](`${nconf.get('url')}/api/v3${urlPath}`, options);
};

before(async () => {
Expand Down Expand Up @@ -158,21 +176,21 @@
});

it('should fail to create a new chat room with invalid data', async () => {
const { body } = await callv3API('post', '/chats', {}, 'foo');
const { body } = await callv3API({ method: 'post', path: '/chats', body: {}, user: 'foo' });
assert.equal(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));
});

it('should return rate limit error on second try', async () => {
const oldValue = meta.config.chatMessageDelay;
meta.config.chatMessageDelay = 1000;

await callv3API('post', '/chats', {
await callv3API({ method: 'post', path: '/chats', body: {

Check failure on line 187 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break after this opening brace
uids: [mocks.users.baz.uid],
}, 'foo');
}, user: 'foo' });

Check failure on line 189 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break before this closing brace

const { response, body } = await callv3API('post', `/chats`, {
const { response, body } = await callv3API({ method: 'post', path: `/chats`, body: {

Check failure on line 191 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break after this opening brace
uids: [mocks.users.baz.uid],
}, 'foo');
}, user: 'foo' });

Check failure on line 193 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break before this closing brace

assert.equal(response.statusCode, 400);
assert.equal(body.status.code, 'bad-request');
Expand All @@ -182,9 +200,9 @@

it('should create a new chat room', async () => {
await User.setSetting(mocks.users.baz.uid, 'disableIncomingMessages', '0');
const { body } = await callv3API('post', `/chats`, {
const { body } = await callv3API({ method: 'post', path: `/chats`, body: {

Check failure on line 203 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break after this opening brace
uids: [mocks.users.baz.uid],
}, 'foo');
}, user: 'foo' });

Check failure on line 205 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break before this closing brace
await User.setSetting(mocks.users.baz.uid, 'disableIncomingMessages', '1');

roomId = body.response.roomId;
Expand All @@ -198,19 +216,19 @@
assert.strictEqual(messages[0].system, 1);
assert.strictEqual(messages[0].content, 'user-join');

const { response, body: body2 } = await callv3API('put', `/chats/${roomId}/messages/${messages[0].messageId}`, {
const { response, body: body2 } = await callv3API({ method: 'put', path: `/chats/${roomId}/messages/${messages[0].messageId}`, body: {

Check failure on line 219 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break after this opening brace
message: 'test',
}, 'foo');
}, user: 'foo' });

Check failure on line 221 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break before this closing brace
assert.strictEqual(response.statusCode, 400);
assert.equal(body2.status.message, await translator.translate('[[error:cant-edit-chat-message]]'));
});

it('should fail to add user to room with invalid data', async () => {
let { response, body } = await callv3API('post', `/chats/${roomId}/users`, {}, 'foo');
let { response, body } = await callv3API({ method: 'post', path: `/chats/${roomId}/users`, body: {}, user: 'foo' });
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));

({ response, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [null] }, 'foo'));
({ response, body } = await callv3API({ method: 'post', path: `/chats/${roomId}/users`, body: { uids: [null] }, user: 'foo' }));
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});
Expand All @@ -222,33 +240,33 @@
});

it('should get users in room', async () => {
const { body } = await callv3API('get', `/chats/${roomId}/users`, {}, 'foo');
const { body } = await callv3API({ method: 'get', path: `/chats/${roomId}/users`, body: {}, user: 'foo' });
assert(Array.isArray(body.response.users));
assert.strictEqual(body.response.users.length, 3);
});

it('should throw error if user is not in room', async () => {
const { response, body } = await callv3API('get', `/chats/${roomId}/users`, {}, 'bar');
const { response, body } = await callv3API({ method: 'get', path: `/chats/${roomId}/users`, body: {}, user: 'bar' });
assert.strictEqual(response.statusCode, 403);
assert.equal(body.status.message, await translator.translate('[[error:no-privileges]]'));
});

it('should fail to add users to room if max is reached', async () => {
meta.config.maximumUsersInChatRoom = 2;
const { response, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.bar.uid] }, 'foo');
const { response, body } = await callv3API({ method: 'post', path: `/chats/${roomId}/users`, body: { uids: [mocks.users.bar.uid] }, user: 'foo' });
assert.strictEqual(response.statusCode, 400);
assert.equal(body.status.message, await translator.translate('[[error:cant-add-more-users-to-chat-room]]'));
meta.config.maximumUsersInChatRoom = 0;
});

it('should fail to add users to room if user does not exist', async () => {
const { response, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [98237498234] }, 'foo');
const { response, body } = await callv3API({ method: 'post', path: `/chats/${roomId}/users`, body: { uids: [98237498234] }, user: 'foo' });
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});

it('should fail to add self to room', async () => {
const { response, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.foo.uid] }, 'foo');
const { response, body } = await callv3API({ method: 'post', path: `/chats/${roomId}/users`, body: { uids: [mocks.users.foo.uid] }, user: 'foo' });
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:cant-chat-with-yourself]]'));
});
Expand All @@ -258,7 +276,7 @@
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));

({ response, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [98237423] }, 'foo'));
({ response, body } = await callv3API({ method: 'delete', path: `/chats/${roomId}/users`, body: { uids: [98237423] }, user: 'foo' }));
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});
Expand Down Expand Up @@ -295,13 +313,13 @@
});

it('should change owner when owner leaves room', async () => {
const { body } = await callv3API('post', '/chats', {
const { body } = await callv3API({ method: 'post', path: '/chats', body: {

Check failure on line 316 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break after this opening brace
uids: [mocks.users.foo.uid],
}, 'herp');
}, user: 'herp' });

Check failure on line 318 in test/messaging.js

View workflow job for this annotation

GitHub Actions / test 

Expected a line break before this closing brace

await callv3API('post', `/chats/${body.response.roomId}/users`, { uids: [mocks.users.baz.uid] }, 'herp');
await callv3API({ method: 'post', path: `/chats/${body.response.roomId}/users`, body: { uids: [mocks.users.baz.uid] }, user: 'herp' });

await callv3API('delete', `/chats/${body.response.roomId}/users/${mocks.users.herp.uid}`, {}, 'herp');
await callv3API({ method: 'delete', path: `/chats/${body.response.roomId}/users/${mocks.users.herp.uid}`, body: {}, user: 'herp' });

assert(await Messaging.isRoomOwner(mocks.users.foo.uid, roomId));
});
Expand Down Expand Up @@ -329,44 +347,44 @@
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));

({ response, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [null] }, 'foo'));
({ response, body } = await callv3API({ method: 'delete', path: `/chats/${roomId}/users`, body: { uids: [null] }, user: 'foo' }));
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});

it('should fail to remove user from room if user does not exist', async () => {
const { response, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [99] }, 'foo');
const { response, body } = await callv3API({ method: 'delete', path: `/chats/${roomId}/users`, body: { uids: [99] }, user: 'foo' });
assert.strictEqual(response.statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});

it('should remove user from room', async () => {
const { response, body } = await callv3API('post', `/chats`, {
const { response, body } = await callv3API({ method: 'post', path: `/chats`, body: {
uids: [mocks.users.herp.uid],
}, 'foo');
}, user: 'foo' });
const { roomId } = body.response;
assert.strictEqual(response.statusCode, 200);

let isInRoom = await Messaging.isUserInRoom(mocks.users.herp.uid, roomId);
assert(isInRoom);

await callv3API('delete', `/chats/${roomId}/users`, { uids: [mocks.users.herp.uid] }, 'foo');
await callv3API({ method: 'delete', path: `/chats/${roomId}/users`, body: { uids: [mocks.users.herp.uid] }, user: 'foo' });
isInRoom = await Messaging.isUserInRoom(mocks.users.herp.uid, roomId);
assert(!isInRoom);
});

it('should fail to send a message to room with invalid data', async () => {
let { body } = await callv3API('post', `/chats/abc`, { message: 'test' }, 'foo');
let { body } = await callv3API({ method: 'post', path: `/chats/abc`, body: { message: 'test' }, user: 'foo' });
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-data]]'));

({ body } = await callv3API('post', `/chats/1`, {}, 'foo'));
({ body } = await callv3API({ method: 'post', path: `/chats/1`, body: {}, user: 'foo' }));
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, message]]'));
});

it('should fail to send chat if content is empty', async () => {
const { body } = await callv3API('post', `/chats/${roomId}`, {
const { body } = await callv3API({ method: 'post', path: `/chats/${roomId}`, body: {
message: ' ',
}, 'foo');
}, user: 'foo' });
const { status, response } = body;

assert.deepStrictEqual(response, {});
Expand All @@ -390,7 +408,7 @@
const oldValue = meta.config.chatMessageDelay;
meta.config.chatMessageDelay = 1000;

await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
await callv3API({ method: 'post', path: `/chats/${roomId}`, body: { roomId: roomId, message: 'first chat message' }, user: 'foo' });
const { body } = await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
const { status } = body;
assert.equal(status.message, await translator.translate('[[error:too-many-messages]]'));
Expand Down
Loading