fix: replace yesterday with tomorrow in activity date selector - #300
Open
srush0 wants to merge 1 commit into
Open
fix: replace yesterday with tomorrow in activity date selector#300srush0 wants to merge 1 commit into
srush0 wants to merge 1 commit into
Conversation
suraj-yadav0
requested changes
Aug 23, 2026
suraj-yadav0
left a comment
Collaborator
There was a problem hiding this comment.
Hi @srush0 , Please raise the PR against the new release branch [release/v1.3.3]. Never raise the PR against the main branch.
suraj-yadav0
requested changes
Aug 24, 2026
suraj-yadav0
left a comment
Collaborator
There was a problem hiding this comment.
DaySelector.qml is used in two places across the app, In Timesheet.qml and in Activities.qml.
Though this PR will work with Activities , It will break Functionality in Timesheets , where Users need to log Hours of Yesterday.
Recommended Fix:
Add a configurable bool property in DaySelector.qml
property bool showTomorrow: false
// In updateModelData() / updateDate() / setSelectedDate()
const offsetDay = new Date(today);
if (showTomorrow) {
offsetDay.setDate(offsetDay.getDate() + 1);
} else {
offsetDay.setDate(offsetDay.getDate() - 1);
}
const offsetLabel = showTomorrow ? i18n.dtr("ubtms", "Tomorrow") : i18n.dtr("ubtms", "Yesterday");
Then in Activities.qml:
DaySelector {
id: date_widget
showTomorrow: true
...
}
So Timesheet continues Using Yesterday and Activites has Enhaced Date Selction .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Problem
The Activity Date Selector provided
Yesterdayas a predefined option, which was not suitable for setting upcoming activity due dates. It also needed to support selecting arbitrary custom dates reliably.Changes
Yesterdayoption withTomorrow.customDatehandling so custom date selection does not interfere with the current date until the picker is closed.Testing
git diff --checkpasses.clickable installwas unavailable because no external device was detected.Related Issue
Fixes #299