fix: support activity types for local account - #296
Merged
suraj-yadav0 merged 3 commits intoAug 24, 2026
Merged
Conversation
suraj-yadav0
requested changes
Aug 21, 2026
Collaborator
There was a problem hiding this comment.
The core logic and database initialization for Local Account activity types are solid..Good Work..!!
In Activity_Page.qml:340, Activity.getActivityTypeName is called with only 1 argument in two locations:
- Activity List Model construction (Activity_Page.qml:340):
// Current:
activity_type_name: Activity.getActivityTypeName(item.activity_type_id),
// Recommended:
activity_type_name: Activity.getActivityTypeName(item.activity_type_id, item.account_id),
- Local Page Search filtering (Activity_Page.qml:578):
// Current:
var activityTypeName = Activity.getActivityTypeName(item.activity_type_id);
// Recommended:
var activityTypeName = Activity.getActivityTypeName(item.activity_type_id, item.account_id);
Just a Two Line change to ensure the Correct Activity Type is called for Correct Account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Problem
Local Accounts do not receive activity types from Odoo because they are not synchronized with an Odoo server. This caused activity types to be unavailable or incorrectly resolved when creating and displaying activities for the Local Account.
Changes
idfor Local Account activities andodoo_record_idfor Odoo account activities.ActivityDetailsCard.qmlto displayNo Typeinstead ofType ID: -1when no activity type is available.Testing
git diff --checksuccessfully.clickable launchbecause no device was detected.Related Issue
Fixes the Local Account activity type handling issue.