Fix backwards compatibility issue#105
Open
JordanLaserGit wants to merge 6 commits into
Open
Conversation
quinnylee
reviewed
Jul 23, 2026
| echo "COMMAND: docker run --rm -v "$NGEN_RUN":"$DOCKER_MOUNT" \ | ||
| echo "COMMAND: docker run --rm -v "$NGEN_RUN":"$DOCKER_MOUNT" \ | ||
| -u $(id -u):$(id -g) \ | ||
| -e TROUTE_RESTART_FILE="${RESTART_BASE:+$DOCKER_MOUNT/restart/$RESTART_BASE}" -e TROUTE_CROSSWALK_FILE="${CROSSWALK_BASE:+$DOCKER_MOUNT/restart/$CROSSWALK_BASE}" \ |
Collaborator
There was a problem hiding this comment.
What a neat bash operator trick. I'm stealing this
quinnylee
requested changes
Jul 23, 2026
|
|
||
| ## Getting Started | ||
| * **Installation:** Follow the [Installation Guide](https://github.com/CIROH-UA/datastreamcli/blob/main/INSTALL.md) to prepare your environment for `DataStreamCLI`. | ||
| * **Tutorial:** New to `DataStreamCLI`? Work through the [Getting Started guide](https://github.com/CIROH-UA/datastreamcli/blob/main/docs/GETTING_STARTED.md) — progressive, explained examples that build from the minimal command up to reproducing a Research DataStream simulation. |
Collaborator
There was a problem hiding this comment.
This link doesn't point to anything. Was this file meant to be added to this PR?
Collaborator
Author
There was a problem hiding this comment.
This is why I shouldn't dev at night. Meant to push this to a different branch... 🙃
Collaborator
|
Overall looks like a good PR. All the pytests are passing locally, and the failing CI test seems to be unrelated to this change. Only change I would want is in the README addition that doesn't point to an existing markdown file. |
quinnylee
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores backward compatibility with older datastream containers (issue #103): t-route restart/crosswalk args are now handed to datastream config gen, bmi-config-gen, and validation steps via environment variables instead of CLI flags, so older containers ignore them rather than erroring on unrecognized arguments. Also adds a manual workflow to test deployed container combinations.
Additions
.github/workflows/test_datastream_backward_compatibility.yamlthat runs the datastream against each deployed DS/FP/NGIAB combination, or a custom combo passed as inputs.Removals
--troute_restart/--troute_crosswalk(_file) CLI flags from theconfigure_datastream.py,ngen_configs_gen.py, andrun_validator.pydocker invocations.RESTART_BASEbranching in the ngen config-gen step.Changes
scripts/datastreampasses t-route restart/crosswalk to those three steps viadocker run -eenv vars.configure_datastream.py,ngen_configs_gen.py, andrun_validator.pydefault those args from the corresponding env vars.Testing
Screenshots
Notes
The docker version combinations that are used in the NRDS are hardcoded into the workflow. It'll accept another combination as args, but that combinations structure will ideally be updated with NRDS releases.
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other