Skip to content

fix(ingest): trust CADC over _report.txt when deciding tile status #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sebokolodi merged 1 commit into from
Jun 11, 2026
Merged

fix(ingest): trust CADC over _report.txt when deciding tile status #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions possum_pipeline_control/ingest3Dpipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,23 @@ def do_ingest(
# if this fails with SSLError, try to run cadc-get-cert -u <username> on CANFAR
CADCsuccess, date = check_CADC(tilenumber, band, CADC_cert_file)

# CADC is the source of truth for ingest success: if all expected products are
# in CADC, the tile is ingested regardless of what `_report.txt` says about this
# particular run. _report.txt only records per-file outcomes of the current attempt,
# so transient minoc timeouts on files that were already uploaded by a prior partial
# run produce false-negative IngestFailed status (seen on tiles 11720, 11532, 11846).
status = "IngestFailed"
if success:
if CADCsuccess:
status = "Ingested"
else:
print("_report.txt reports succesful ingest, but CADC ingest failed")
if CADCsuccess:
status = "Ingested"
if not success:
print(
"_report.txt reports per-file errors but CADC contains all expected "
"products; treating as Ingested."
)
elif success:
print("_report.txt reports successful ingest but CADC is missing products.")
else:
print("_report.txt reports that ingestion failed")
print("_report.txt reports that ingestion failed and CADC is missing products.")

# Record the status in the POSSUM Validation database
conn = db.get_database_connection(test=False)
Expand Down
Loading