feat(i18n): add Chinese (zh-CN) localization - #15
Open
ShenZiLi wants to merge 3 commits into
Open
Conversation
- Extract 26 hardcoded UI strings to .resx resources (neutral English fallback) - Add Resources.zh-CN.resx satellite assembly for Simplified Chinese - Update Program.cs, TrayIcon.cs, Tools.cs, ConfigureAppsForm(.cs/.Designer.cs) to use Properties.Resources references with string.Format for placeholders - Register Resources.zh-CN.resx as embedded resource in NoSleep.csproj - Translate readme.md, BUILD.md, CONTRIBUTING.md to zh-CN with language switcher links Language is auto-selected at runtime via CurrentUICulture; English remains the default fallback for non-zh-CN systems. Brand name "NoSleep", mutex GUID, and autostart shortcut filename are intentionally not localized.
Owner
|
I've seen your PR. I also see it's at least partially AI-generated. GitHub workflow uses a different publishing. I really appreciate the work you've done on introducing i18n and github workflow, but I need to do a more thorough review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language is auto-selected at runtime via CurrentUICulture; English remains the default fallback for non-zh-CN systems. Brand name "NoSleep", mutex GUID, and autostart shortcut filename are intentionally not localized.