Repository navigation
Investigate EOS update. #11
Description
Activity
[Comment by dweir on 2021-10-27]
NB the original Fortran code on which our code is based only calls the EOS update after advection.
[Comment by dweir on 2021-10-27]
We also only do the pressure work once, which again is consistent with the Fortran code but not W&M. Should check this carefully.
[Comment by dweir on 2021-10-27]
Discussion with Mark: loss of total energy but relatively good conservation of kinetic energy might be due to not updating the EOS after doing the advection, because then although kinetic energy gets advected okay, work done on the fluid might not be properly taken into account. This might be interesting for @{557058:ceeca0b6-b524-4a8e-a46b-b54c39a5a423} 's recent bubble runs.
Check effect of calling update of equation of state multiple times in update of dynamical quantities, ala W&M. Currently we only do it once per timestep.
[Issue created by DanielCutting: 2021-10-27]