main BUGFIX fix empty rpc-reply - #1759
Merged
Merged
Conversation
When an RPC output has a container and the RPC callback returns nothing, the np2srv_rpc_cb does not add the 'ok' empty leaf. The rpc-reply is empty. The client receives an error when it reads the RPC response with nc_recv_reply, because it expects either 'ok' or 'data'. Look at the content of the reply and add the 'ok' leaf if no child with the default flag is found. Fixes: 3936132 ("server UPDATE call NC RPC directly, not using sysrepo") Link: https://datatracker.ietf.org/doc/html/rfc7950#section-7.14.4 Link: https://datatracker.ietf.org/doc/html/rfc6241#section-4.4
michalvasko
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an RPC output has a container and the RPC callback returns nothing, the np2srv_rpc_cb does not add the 'ok' empty leaf. The rpc-reply is empty.
The client receives an error when it reads the RPC response with nc_recv_reply, because it expects either 'ok' or 'data'. Look at the content of the reply and add the 'ok' leaf if no child with the default flag is found.
Fixes: 3936132 ("server UPDATE call NC RPC directly, not using sysrepo")
Link: https://datatracker.ietf.org/doc/html/rfc7950#section-7.14.4
Link: https://datatracker.ietf.org/doc/html/rfc6241#section-4.4