refactor: simplify ShigaPass/FastANI taxonomy reconciliation logic - #224
Open
weichisyu wants to merge 1 commit into
Open
refactor: simplify ShigaPass/FastANI taxonomy reconciliation logic#224weichisyu wants to merge 1 commit into
weichisyu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify ShigaPass taxonomy reconciliation ( issue #223)
This PR moves the ShigaPass/FastANI taxonomy reconciliation logic into
check_taxa.pyinstead of splitting the decision-making between the Nextflow process and Python script.Changes
check_taxa.pyShigellaEscherichiawhen the result isEIECorNot Shigella/EIECEscherichiacalls toShigellawhen ShigaPass identifies a Shigella type.Shigellacalls toEscherichia coliwhen ShigaPass reportsEIECorNot Shigella/EIEC.EscherichiaorShigellaWhy update all Shigella species?
ShigaPass reports Shigella species using abbreviated identifiers such as
SS,SF,SB, andSD, whereas the FastANI taxonomy contains full species names.The previous Bash comparison therefore generally treats the ShigaPass and FastANI species values as different and passes the sample to
check_taxa.pyanyway.Instead of keeping this redundant comparison in Nextflow, this PR sends the reconciliation decision directly to Python.
When ShigaPass identifies a sample as Shigella, the ShigaPass species assignment is used to update the taxonomy.
Resulting logic
This keeps the reconciliation logic in one place and makes the intended relationship between FastANI and ShigaPass easier to understand and maintain.