Skip to content

Switch to join-based PRISM category lookup - #265

Open
dylanhmorris wants to merge 4 commits into
mainfrom
dhm-join-based-category-lookup
Open

Switch to join-based PRISM category lookup#265
dylanhmorris wants to merge 4 commits into
mainfrom
dhm-join-based-category-lookup

Conversation

@dylanhmorris

@dylanhmorris dylanhmorris commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Closes #264

Also makes as_of potentially vectorized in cutpoint lookup, which is relevant for (e.g.) defining true categories for a timeseries of dates that spans cutpoint revisions.

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.64%. Comparing base (56ac56c) to head (f2e33fe).

Files with missing lines Patch % Lines
R/categorize_prism.R 87.93% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   75.51%   75.64%   +0.13%     
==========================================
  Files          37       37              
  Lines        2091     2131      +40     
==========================================
+ Hits         1579     1612      +33     
- Misses        512      519       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylanhmorris
dylanhmorris marked this pull request as ready for review September 6, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compare iterated filter to join in vectorized lookups

1 participant