Use NHSN HRD For Population Operations - #256
Draft
O957 wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 75.51% 74.98% -0.53%
==========================================
Files 37 38 +1
Lines 2091 2123 +32
==========================================
+ Hits 1579 1592 +13
- Misses 512 531 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
O957
marked this pull request as ready for review
August 21, 2026 19:29
Contributor
Author
|
Need to update CDCgov/hubhelpr#242 as well. |
damonbayer
reviewed
Aug 24, 2026
| dplyr::select( | ||
| "weekendingdate", | ||
| "jurisdiction", | ||
| count = tidyselect::all_of(admissions_columns[["count"]]), |
Collaborator
There was a problem hiding this comment.
Aren't admissions_columns[["count"]] and admissions_columns[["rate"]] scalars? If so, you shouldn't need all_of
O957
marked this pull request as draft
August 25, 2026 13:39
1 task
Collaborator
|
@O957 I think we should close per my comments here: CDCgov/hubhelpr#242 (comment) See also our previous decision not to make less-generic dataset pullers in #180 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functions to pull NHSN HRD.