Add PRISM Rate Reference Population Vintaging - #255
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 75.22% 75.51% +0.28%
==========================================
Files 36 37 +1
Lines 2067 2091 +24
==========================================
+ Hits 1555 1579 +24
Misses 512 512 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…d prism_reference_population function
Contributor
Author
|
Still need to add some tests and update the description of the PR. |
O957
marked this pull request as ready for review
August 19, 2026 13:10
dylanhmorris
requested changes
Aug 19, 2026
dylanhmorris
left a comment
dylanhmorris
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @O957! A few changes requested but I think this can and should land quickly
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
for more information, see https://pre-commit.ci
Collaborator
|
Thanks @O957. Let's wait to land this until we get the additional locations we're missing, and then add checks for presence of expected locations to the data generation script and the test suite. |
dylanhmorris
requested changes
Aug 21, 2026
dylanhmorris
left a comment
dylanhmorris
left a comment
Collaborator
There was a problem hiding this comment.
A few quick final changes. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
data/prism_rate_reference_populations.rda).