Skip to content

Update hubverse-to-scorable functions to reflect new hubverse target data conventions. - #186

Merged
dylanhmorris merged 22 commits into
mainfrom
dhm-scorable-with-hubverse
Aug 15, 2025
Merged

Update hubverse-to-scorable functions to reflect new hubverse target data conventions.#186
dylanhmorris merged 22 commits into
mainfrom
dhm-scorable-with-hubverse

Conversation

@dylanhmorris

@dylanhmorris dylanhmorris commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

Closes #165
Closes #137

  • Replaces manual point at target data and join specification with accessing oracle output data (where available) via hubData.
  • Updates vignette accordingly
  • Leaves quantile_table_to_scorable() for now but we can consider deprecating
  • Adds tests

@codecov

codecov Bot commented Aug 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.12%. Comparing base (ef53469) to head (0838ee5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/hubverse_to_scorable.R 67.92% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   72.01%   73.12%   +1.10%     
==========================================
  Files          33       34       +1     
  Lines        1837     1905      +68     
==========================================
+ Hits         1323     1393      +70     
+ Misses        514      512       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylanhmorris
dylanhmorris marked this pull request as ready for review August 14, 2025 21:14
@dylanhmorris
dylanhmorris requested a review from sbidari August 15, 2025 17:32

@sbidari sbidari left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dylanhmorris

@dylanhmorris
dylanhmorris merged commit 6709f56 into main Aug 15, 2025
13 checks passed
@dylanhmorris
dylanhmorris deleted the dhm-scorable-with-hubverse branch August 15, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants