Skip to content

Manual approval of dagster test runs is unergonomic #1288

Description

@damonbayer

Manual approval of Azure Batch Dagster (ABD) test interacts poorly with the max queue strategy.

New container images don't get built because previous actions don't "complete" until we explicitly approve or disapprove the ABD test.

We want the max queue strategy because sometimes the container action determines that the container doesn't need to be built. We don't want the non-build to cancel an in-progress build.

Hopefully there is some way to separate the ABD test from the container action, although the container action is a prereq for the ABD test.

Ex: https://github.com/CDCgov/cfa-stf-routine-forecasting/blob/2eb5f4330f002dcdec35b06846740c07544b2440/.github/workflows/containers.yaml#L25C3-L25C13

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions