Abstract Hecke ring: the Ring (π P β€) instance - #78
Draft
CBirkbeck wants to merge 1 commit into
Draft
Conversation
Prove Ring (π P β€) for the abstract Hecke ring of a Hecke pair (Shimura, Ch. 3): the double-coset quotient basis (Basic), the convolution product via Shimura's integer multiplicities (Multiplication), the module action used in the associativity argument (Module), associativity (Associativity), and the Ring instance (Ring). Only the ring structure -- commutativity, the degree map, and further API are left to follow-up PRs. Part of #75. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract Hecke ring: the
RinginstanceA focused PR proving that the abstract Hecke ring is a
Ringβ and nothing more. Following Shimura, Introduction to the Arithmetic Theory of Automorphic Functions, Ch. 3.New
LeanBridge/ForMathlib/AbstractHeckeRing/with exactly the files needed forRing (π P β€):Basicβ the Hecke pairHeckePair, the double-coset quotientHeckeCoset, and the Hecke ring typeπ;Multiplicationβ the convolution product via Shimura's integer multiplicities;Moduleβ the module action ofπon the left-coset module (used by the associativity argument);Associativityβ associativity of the convolution;Ringβ the resultingRing (π P β€)instance (NonUnitalSemiring β NonAssocSemiring β Semiring β NonAssocRing β Ring).Scope (deliberately minimal)
Moduleis included because the associativity proof goes through the module-action scalar tower (Ring β Associativity β Module β Multiplication β Basic); it is a proof dependency, not extra scope.β€. Generalising the ring/module layer to an arbitrary commutative ringRis a separate follow-up.Verification
β
lake buildclean against pinned mathlibv4.31.0(1830 jobs). Nosorry/axiom. Ported from the AINTLIB project (projects/LeanModularForms/.../AbstractHeckeRing).Part of #75. (Supersedes the everything-at-once #77 for the ring part; commutativity/module-API/degree will land as their own PRs.)