New pipeline function for code usage | Updates on torch version - #64
Open
spirosmaggioros wants to merge 7 commits into
Open
New pipeline function for code usage | Updates on torch version#64spirosmaggioros wants to merge 7 commits into
spirosmaggioros wants to merge 7 commits into
Conversation
…e torch version(tested) | Added test case for BIDS I/O
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 71.03% 72.42% +1.39%
==========================================
Files 3 3
Lines 290 301 +11
==========================================
+ Hits 206 218 +12
+ Misses 84 83 -1
🚀 New features to boost your workflow:
|
AlexanderGetka-cbica
left a comment
AlexanderGetka-cbica
left a comment
Contributor
There was a problem hiding this comment.
NiChart_Project (unfortunately) already relies on the run_pipeline interface. Can you change the function name quickly then ping me? Otherwise looks fine.
Member
Author
@AlexanderGetka-cbica It's run_ndlmuse_pipeline, i don't see the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the torch version for up to 2.3.1 for now. The pipeline is tested and the torch version of the other packages(DLMUSE, DLICV, DLWMLS and Spare) will be updated as well once tested.
Also, implemented @AlexanderGetka-cbica 's request for a pipeline function (run_dlicv_pipeline) so it can be used instead of calling the CLI command inside third-party code.
Also, good thing that the installation of torch with cuda works well. Just fyi the pipeline works with torch 2.4.* versions as well(tested this because cuda 12.4 doesn't support 2.3.1)
P.S: Thanks for the VM Alex.