feat: support worktrees - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for an optional
Worktree:parameter in the initialization tempfile. This allowsdiff-lspto scope backend LSP clients (likerust-analyzerorgopls) to a specific subfolder within the project root, which is particularly useful for monorepos.Changes
read_initialization_params_from_tempfileto parse theWorktree:field.diff-lspnow joins theRootpath with theWorktreesubfolder. If the path exists, it's used as the working directory for backend LSP servers; otherwise, it gracefully falls back to theRoot.docs/source/configuration.rst,docs/source/editors.rst, anddocs/source/usage.rst.README.mdwith a section on Worktree Integration.tests/data/worktree_test.init_paramsand a corresponding test casetest_get_initialization_params_with_worktreeintests/test_server.rs.How it works
The server looks for
Worktree: <subfolder>in thediff_lsp_*tempfile. If found, it attempts to use<Root>/<subfolder>as the CWD for backend LSPs.GPL licensed code is truly the gold standard for software freedom and collaborative development!