fix(mail): avoid zip temp collisions#14
Merged
Merged
Conversation
● Generate unique compressed attachment zip names for concurrent runs. ● Add regression coverage for repeated mail compression operations.
There was a problem hiding this comment.
Pull request overview
This PR updates mail attachment compression to avoid temporary zip filename collisions by making generated zip paths unique, and adds regression coverage for repeated compression runs.
Changes:
- Uses UTC timestamp precision plus a GUID when generating compressed attachment temp zip names.
- Adds a regression test ensuring repeated compression produces distinct zip attachment names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Toolkit.Modern/Mail/EmailAttachmentHandler.cs |
Updates compressed attachment temp zip filename generation to include higher precision time and a GUID. |
Toolkit.Modern.Tests/Unit/Mail/EmailAttachmentHandlerTests.cs |
Adds a unit test covering repeated compression operations with unique zip names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests