feat: added the missing timelockDelay field to Step2_ReviewConfig

[dan13ram]

Summary by CodeRabbit

• New Features
  • Added a configurable Timelock Delay field to the cross-chain migration Step 2 review form.
  • Users can set the delay from 5 minutes up to 24 weeks, with input validation and inline error messaging.
  • The selected timelock delay is persisted with the saved migration configuration and shown in the Governance Settings UI.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
testnet-nouns-builder	Ready	Preview	Jul 22, 2026 10:31am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
nouns-builder	Ignored		Jul 22, 2026 10:31am

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22abfaac-64ee-4c08-a6c6-ae4f80857c97

📥 Commits

Reviewing files that changed from the base of the PR and between 2fcc88c and f94f915.

📒 Files selected for processing (2)

• packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.schema.ts
• packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.tsx

---

📝 Walkthrough

Walkthrough

Adds a configurable timelock delay to the cross-chain migration review form, including five-minute-to-24-week validation, config loading, UI editing, and persistence in the deployment payload.

Changes

Timelock Delay Configuration

Layer / File(s)	Summary
Timelock delay validation packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.schema.ts	Adds timelockDelay to the form values and validates it between five minutes and twenty-four weeks.
Timelock delay form flow packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.tsx	Initializes and loads the delay, renders a DaysHoursMinsSecs control, and converts the value into the saved configuration payload.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• BuilderOSS/nouns-builder#984: Adds the timelock delay field and UI wiring to the same Step 2 cross-chain migration form flow.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so none of the required template sections are filled out.	Add the Description, Motivation & context, Code review, Type of change, and Checklist sections from the template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding the missing timelockDelay field to Step2_ReviewConfig.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/updatable-proposals

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.tsx`:
- Around line 89-91: Update the timelockDelay initialization in
Step2_ReviewConfig to avoid passing 0n when config.timelockDelay is absent or
not a bigint. Use the documented default that satisfies
Step2_ReviewConfig.schema.ts’s five-minute minimum, or route invalid/missing
values through the explicit migration state requiring user input.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6d09a710-11c2-4545-896b-cad7e4e8bb2c

📥 Commits

Reviewing files that changed from the base of the PR and between c9ce5e3 and 2fcc88c.

📒 Files selected for processing (2)

• packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.schema.ts
• packages/create-proposal-ui/src/components/TransactionForm/CrossChainMigration/Step2_ReviewConfig.tsx