Skip to content

fix: candidate propose card copy#983

Merged
dan13ram merged 1 commit into
stagingfrom
feat/updatable-proposals
Jul 21, 2026
Merged

fix: candidate propose card copy#983
dan13ram merged 1 commit into
stagingfrom
feat/updatable-proposals

Conversation

@dan13ram

@dan13ram dan13ram commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated candidate promotion cards to show voting progress based solely on sponsor signature support.
    • Corrected progress percentages and descriptions when no signature votes are present.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
testnet-nouns-builder Ready Ready Preview Jul 21, 2026 12:21pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
nouns-builder Ignored Ignored Jul 21, 2026 12:21pm

Request Review

@dan13ram
dan13ram merged commit 612a0f1 into staging Jul 21, 2026
2 of 4 checks passed
@dan13ram
dan13ram deleted the feat/updatable-proposals branch July 21, 2026 12:12
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2dcdcd3-c5f0-4192-97bd-0f0cbaf86906

📥 Commits

Reviewing files that changed from the base of the PR and between 10fe446 and e6adc61.

📒 Files selected for processing (1)
  • packages/candidate-ui/src/components/CandidatePromoteCard/CandidatePromoteCard.tsx

📝 Walkthrough

Walkthrough

The candidate promotion card now displays and calculates progress from aggregated sponsor signature voting weight, excluding creator voting power.

Changes

Candidate promotion display

Layer / File(s) Summary
Use signature weight for card calculations
packages/candidate-ui/src/components/CandidatePromoteCard/CandidatePromoteCard.tsx
Description values and progress percentages now use totalSignatureWeight, with zero signature weight producing 0% progress and results capped at 100%.

Estimated code review effort: 2 (Simple) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/updatable-proposals

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant