UX: connect dialogs, guided Vercel walkthrough & flow clarity#6
Open
mtlouzada wants to merge 2 commits into
Open
UX: connect dialogs, guided Vercel walkthrough & flow clarity#6mtlouzada wants to merge 2 commits into
mtlouzada wants to merge 2 commits into
Conversation
The status poll only handled READY and ERROR, so a CANCELED build or a persistent status failure (expired session, deleted deployment) left the Building screen spinning indefinitely. - treat CANCELED as a terminal state -> error screen - count consecutive failed polls (non-ok response, missing deployment, or thrown error) and bail to the error screen after ~30s instead of looping - a successful poll resets the counter, so transient blips are tolerated Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Connect cards now open a confirm dialog instead of redirecting straight to the provider (rendered via portal so the overlay clears the fixed Back/Theme controls). - Vercel dialog is a step-by-step carousel with annotated screenshots (one large image per step, dot indicators, arrow-key nav). - GitHub dialog stays lightweight with an "Authorize" button hint. - Set expectations up front: welcome names Vercel + GitHub, and each connect screen shows "Connection 1/2" / "2/2 — the last one". - QuestionHeader step label is now a readable "Step N" badge with a backdrop so it stays visible over the animated background. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@mtlouzada is attempting to deploy a commit to the sktbrd's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishing the Vercel/GitHub connect flow: confirmation dialogs (portal-rendered), a guided Vercel screenshot carousel, GitHub Authorize hint, up-front 'Connection 1/2 / 2/2' expectations, and a readable 'Step N' badge. Adds public/vercel-guide/ assets.
Commits: dfcba41 (build-screen spin fix) + 470bb99 (connect dialogs/flow clarity).
NOTE (handoff): the build -> 'You're live' transition was not verified end-to-end yet. Local testing was blocked because the OAuth creds in .env.local are placeholders (VERCEL_INTEGRATION_SLUG=seu-slug, client id/secret are '...'). Whoever picks this up needs a real Vercel OAuth2 integration + GitHub OAuth App, or seed session cookies from personal access tokens for a local shortcut.
Generated with Claude Code