Fx devices/formatting fixes - #1
Open
AntoineBalaine wants to merge 3 commits into
Open
Conversation
BryanChi
marked this pull request as ready for review
July 18, 2023 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm Perken from the reaper forum. I'd love to help with your project, if you're open to that.
I went ahead and applied the formatter stylua, and I used your variable
rwherever possible instead of thereaperglobal. I hope you like it!There's some other low-hanging fruit that I could work on, such as adding some type annotations and maybe try to address the diagnostics warnings such as
undefined global <variablename>. Let me know if you're interested.Last thing: I'm having to open this PR to your «upload» branch rather than to master, because it's more up to date. Let me know if you're interested and I can redirect the PR towards master.