Skip to content

Retire fixed Rust module benchmark expectation - #196

Merged
DavidBakerEffendi merged 1 commit into
mainfrom
dave/retire-rust-module-xfail
Sep 10, 2026
Merged

DavidBakerEffendi merged 1 commit into
mainfrom
dave/retire-rust-module-xfail

Conversation

@DavidBakerEffendi

Copy link
Copy Markdown
Collaborator

Description

Retire the stale Bifrost expected-failure annotation after scheduled benchmark run #34443712253 showed exact module declaration navigation.

Key Changes:

  • Remove the rust-parity-module-declaration-definition expected-failure overlay now that Bifrost returns the exact authored workflow token range.
  • Update the overlay coverage invariant from ten expected failures to nine.

Touch Points:

  • benchmarks/expectations/bifrost-expected-failures.yaml
  • src/runners/bifrost.rs

Validation:

  • Focused overlay invariant test passed.
  • cargo run -- validate benchmarks/cases/rust-lsp-parity.yaml passed.
  • git diff --check passed.
  • Full cargo test: 259 passed, with three unrelated evaluation tests blocked by the existing gohugoio--hugo.tar.gz source hash mismatch; the initially stale overlay-count assertion was updated and then passed independently.
  • Full corpus validation is blocked by the same Go source archive hash mismatch.
  • cargo fmt --check reports only pre-existing drift in src/promotion.rs.

@DavidBakerEffendi
DavidBakerEffendi merged commit 2f11dd9 into main Sep 10, 2026
5 checks passed
@DavidBakerEffendi
DavidBakerEffendi deleted the dave/retire-rust-module-xfail branch September 10, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant