20260702 release prep - #4031
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 825202f2c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Push-Location $RepoRoot | ||
| try { | ||
| $ErrorActionPreference = "Continue" | ||
| $null = git checkout -b $BranchName 2>&1 |
There was a problem hiding this comment.
Create the release branch from dev
When this script is launched from any branch other than the intended dev base, this line now creates the release branch from the caller's current HEAD and the later git push/gh pr create --base dev can include unrelated commits or omit recent dev changes. The previous flow checked out dev before creating $BranchName; after moving branch creation to the end, the script should still validate or switch to dev before git checkout -b.
Useful? React with 👍 / 👎.
|
|
||
|
|
||
| SELECT @Version = '8.32', @VersionDate = '20260407'; | ||
| SELECT @Version = '8.34', @VersionDate = '20260702'; |
There was a problem hiding this comment.
Don't skip the next release version
The parent release metadata is 8.32, and the release-prep script in this same commit is still documented and implemented to bump by 0.01, so this release should report 8.33 rather than 8.34. Because this value is returned by @VersionCheckMode across the shipped procedures, publishing 8.34 here makes the component version metadata inaccurate for users and version-check tooling.
Useful? React with 👍 / 👎.
Summary