Skip to content

Fix Codex review findings from PR 4028 - #4030

Merged
BrentOzar merged 2 commits into
devfrom
codex/fix-pr-4028-review-notes
Jul 2, 2026
Merged

Fix Codex review findings from PR 4028#4030
BrentOzar merged 2 commits into
devfrom
codex/fix-pr-4028-review-notes

Conversation

@BrentOzar

Copy link
Copy Markdown
Member

Summary

Fixes #4029.

Addresses the actionable Codex review findings from PR #4028:

  • removes the duplicate terminated predicate in sp_DatabaseRestore.sql that left a standalone AND
  • keeps sleeping sessions with open transactions visible when sp_BlitzWho @OnlyProblems = 1 and @ShowSleepingSPIDs = 0
  • preserves database scope when sp_BlitzPlanCompare @StoredProcName is supplied as a three-part name
  • passes @DatabaseName through linked-server mode in sp_BlitzPlanCompare

The review items about regenerated install scripts and positional parameter shifts were left alone per Brent's replies on PR #4028.

Testing

Against a disposable SQL Server 2022 Developer Edition container on Docker:

  • sqlcmd -d master -i sp_DatabaseRestore.sql
  • sqlcmd -d master -i sp_BlitzWho.sql
  • sqlcmd -d master -i OptionalScripts/sp_BlitzPlanCompare.sql
  • EXEC dbo.sp_DatabaseRestore @VersionCheckMode = 1;
  • EXEC dbo.sp_BlitzWho @VersionCheckMode = 1;
  • EXEC dbo.sp_BlitzPlanCompare @VersionCheckMode = 1;

sp_DatabaseRestore emitted the expected missing Ola Hallengren dbo.CommandExecute dependency warnings, but compiled successfully.

Copilot AI review requested due to automatic review settings July 2, 2026 13:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13cd4b4e14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sp_BlitzWho.sql
@BrentOzar
BrentOzar merged commit de38214 into dev Jul 2, 2026
1 check passed
@BrentOzar
BrentOzar deleted the codex/fix-pr-4028-review-notes branch July 2, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Codex review findings from PR #4028

2 participants