sp_Blitz: stop flagging version high/low part of SQL Server configs (#4022) - #4023
Closed
BrentOzar wants to merge 1 commit into
Closed
sp_Blitz: stop flagging version high/low part of SQL Server configs (#4022)#4023BrentOzar wants to merge 1 commit into
BrentOzar wants to merge 1 commit into
Conversation
These two sp_configure options ('version high part of SQL Server' and
'version low part of SQL Server') have no "correct" value, so sp_Blitz
should never flag them under Non-Default Server Config no matter what
they're set to. They were removed from sp_Blitz.sql in PR #3906, but the
matching lines in Install-All-Scripts.sql regressed via a later
regeneration. This resyncs Install-All-Scripts.sql with sp_Blitz.sql.
Removing them from #ConfigurationDefaults means CheckID 22's INNER JOIN
no longer matches them, so they're never reported. Fixes #4022.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the installer script with sp_Blitz behavior by removing the two SQL Server “version part” sp_configure options from the seeded #ConfigurationDefaults list so they are no longer eligible to be flagged by CheckID 22 (Non-Default Server Config).
Changes:
- Removed
version high part of SQL Serverfrom#ConfigurationDefaultsin the installer script. - Removed
version low part of SQL Serverfrom#ConfigurationDefaultsin the installer script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4022
Problem
sp_Blitzreportedversion high part of SQL Serverandversion low part of SQL Serverunder Non-Default Server Config (CheckID 22). These twosp_configureoptions have no meaningful "correct" value — they encode the build number — so sp_Blitz should never alert on them no matter what they're set to.They were originally added to the
#ConfigurationDefaultslist in #3657 with hard-coded "defaults" of1114112/52428803. On any server where the actual values differ from those magic numbers (e.g. the reporter set them to0, which Microsoft documents as the default), CheckID 22'sWHERE cdUsed.name IS NULLpredicate fired and flagged them.Fix
Remove both entries from
#ConfigurationDefaults. Because CheckID 22 uses anINNER JOIN #ConfigurationDefaults cd ON cd.name = cr.name, a config that isn't in the list can never be reported — exactly the desired behavior.This was already done for
sp_Blitz.sqlin #3906, but the matching lines inInstall-All-Scripts.sqlregressed (re-introduced by a later regeneration), leaving the two files out of sync. This PR resyncsInstall-All-Scripts.sql.Testing
Verified on a live instance (
sys.configurationsreports both options withvalue/value_in_use=0,configuration_id1593/1594). With these entries absent from#ConfigurationDefaults, neither option appears in the Non-Default Server Config findings regardless of its value.🤖 Generated with Claude Code