Repository navigation
Add verified chain-rule practice and offline tutoring regression coverage - #2
Merged
Merged
Conversation
Offer bounded sine, cosine and exponential composition questions through the existing verified-key practice flow, recap recommendations and My Mistakes. Preserve verifier, uncertainty, accounting and mastery rules. Reuse existing HTTP doubles for ten offline tutoring and guard episodes, with comparable fixture/method hashes, regression reporting, independent symbolic key checks and a browser journey. Repair the existing adaptive report's dependence on catalog ordering. Document scope and limitations.
The chain-rule browser journey can select exp(ax), but the synthetic alphabet had no e or p. Add those two glyphs without changing existing strokes, application behavior or verification rules. Render every distinct generated chain-rule question and answer in a regression so all families remain drawable regardless of random selection. The original hosted failure is retained; all three local browser repetitions and 69 focused offline tests pass before rerunning the full release gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quack already diagnoses missing inner factors and verifies corrections, but chain-rule mistakes could not lead to targeted practice. Add bounded sine, cosine and exponential composition questions to the existing verified-key practice flow, My Mistakes and recap recommendations. Frontend and backend topic types are extended together; routing, inference budgets, PostgreSQL accounting, authentication, verification rules and database schema are unchanged.
Add ten offline API tutoring/failure episodes using existing HTTP doubles and the real isolated verifier, independent symbolic key checks, and a browser journey from a mistake to completed practice. Repair the existing adaptive evaluation report to select Algebra by ID rather than catalog position. These checks measure deterministic software contracts, not handwriting accuracy, learning gains or a student's mental cause.
Validation before merge:
Production rollout is excluded. No Vercel or Modal deployment is authorized by this PR; later rollout must be backend first.
Release verification found and fixed a synthetic browser-fixture omission: generated exponential answers need
eandp, which were absent from the stroke alphabet. Add those glyphs without changing existing glyph data, plus a regression rendering all 27 distinct generated questions and answers. No application behavior or test assertion is weakened. The repaired browser journey passes three local repetitions; 69 focused backend checks pass.Hosted evidence:
01c3546PASSED: https://github.com/Brendan-Lim/Quack/actions/runs/43022128304. All 3,522 backend tests, 361 frontend tests, 249 development browser journeys and nine compiled browser checks passed. Zero required skips or flaky browser cases; dependency audits, publication guard, secret scans, lint, types and build passed.Merged normally as
ec266b50eccfe1dcc6538621161e9cccbe9bf3d2; its source tree exactly matches tested repair head01c3546. Automatic main CI PASSED: https://github.com/Brendan-Lim/Quack/actions/runs/43029006117. It independently reports the same 3,522 backend, 361 frontend, 249 browser journey and nine compiled-browser passes, zero required skips/flaky cases, and all 16 release checks passed.Post-merge read-only provider verification confirms both existing production deployments remain at
6784a07; all 72 Modal runtime files match that baseline, and Vercel's alias/deployment is unchanged. Production deployment remains pending separate authorization. No paid model calls were made.