feat: day-tab filter for multi-day event schedules (#542 PR-3)#636
Merged
Conversation
Multi-day events (Buddies Fest 2, Aug 7-9) get a day-tab segmented control on the schedule (ScheduleView) and personal schedule (MySchedule): selecting a day filters the list to that day's sets, and ?day=N deep-links straight to it. Active day resolves ?day=N → today's festival day if the event is in progress → day 1, using the existing 6 AM after-midnight convention. Single-day events render no tabs at all (never-show-"Day 1" rule). Share Schedule and Lock-In Lineup deliberately read the unfiltered band list so a shared route always covers the whole festival regardless of the active tab. Shared DayTabs component is a proper tablist (roving tabindex, arrow/Home/End keys, aria-selected, 44px targets, theme tokens). Closes #542 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BreakableHoodie
added
enhancement
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-day events get a day-tab segmented control on both the full schedule (
ScheduleView) and the fan's personal schedule (MySchedule). Selecting a day filters the list to that day's sets (Dre's confirmed choice over scroll-anchor), and?day=Ndeep-links straight to a day's lineup — shareable, back-button-sane. Directly serves Buddies Fest 2 (Aug 7–9), the upcoming multi-day event.Closes #542 (final sibling PR — PR-1 staleness #604, PR-2 day-aware ICS, PR-4 subEvent JSON-LD #634)
What changed
frontend/src/utils/festivalDays.jsresolveActiveFestivalDay()— precedence?day=N→ today's festival day if in-progress → day 1, using the existing 6 AM after-midnight convention (untouched)frontend/src/hooks/useFestivalDayFilter.js(new)useSearchParams+ the resolver; syncs the active day to the URLfrontend/src/components/ui/DayTabs.jsx(new)aria-selected, ≥44px targets, theme tokens onlyfrontend/src/components/{ScheduleView,MySchedule}.jsxDayTabsonly whenfestivalDays.length > 1frontend/src/App.jsxfestivalDays(from the full lineup) into MySchedule so a Day-2-only selection isn't mislabelled "Day 1"Deliberate scope calls (flagged, not oversights): Share Schedule + Lock-In Lineup read the unfiltered band list so a shared route covers the whole festival regardless of active tab; the existing
DayDivider(carries #569 doors time) is kept alongside the tabs; single-day events render no tabs (never-show-"Day 1" rule, byte-unchanged).Security / correctness notes
None — client-side view filtering + a URL param. Schedule storage logic untouched; the filter is layered on top.
Verification
festivalDays.length > 1at both call sites — verified)validate:openapi: n/a — frontend only?day=2deep-link, keyboard nav)Built by Sonny · Reviewed by Theo · 🤖 Claude Code