fix: move band-profile Share button into the header#628
Merged
Conversation
The Share button sat in a flex column beside the bio — floating above it on mobile (col-reverse) and forcing an empty right column on desktop, only visible now that bios exist. It's a page-level action: top-right of the photo hero (absolute, over the scrim) and top-right of the no-photo header (flex). The bio takes the full section width; max-w-prose stays as a deliberate reading measure. Requested by Dre. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Share button sat in a flex column beside the bio — floating above it on mobile (
flex-col-reverse) and forcing a mostly-empty right column that compressed the bio on desktop. The layout flaw was invisible until this week because everydescriptionwas empty; the LWBC17 performer-sheet entry exposed it (reported by Dre with screenshots). Share is a page-level action, so it now lives in the header on both variants: absolutely positioned top-right over the photo hero's scrim, and flex top-right beside the name in the no-photo header. The bio takes the full section width —max-w-prosestays as a deliberate reading measure, not a squeeze.What changed
frontend/src/pages/BandProfilePage.jsxmin-w-0title block); bio section unwrapped from the col-reverse flex; placement rationale commentedVerified visually on local wrangler, desktop (1280px) + mobile (390px), screenshots shared with Dre in-session.
Security / correctness notes
None — layout-only. The bio's
dangerouslySetInnerHTMLis unchanged and remains behind the marked→DOMPurify pipeline inutils/markdown.js.Verification
validate:openapi: n/aBuilt by Theo · Reviewed by Theo · 🤖 Claude Code