fix: recap first-timer chronology + roster-only archive noise#624
Merged
Conversation
is_returning now requires a chronologically EARLIER published-or- archived event (date, id tie-break) — a band whose only other appearance was a later edition no longer counts as returning back in time, so Vol 1's recap correctly shows all first-timers. Roster-only archives (no venue/time data) drop the "Venues: 0" tile (grid adjusts to 4 columns), render nothing instead of "TBD-TBD", and head their single group "Lineup" instead of "Unscheduled"; partially-scheduled events keep "Unscheduled" for the genuine leftover group. Closes #613 Closes #614 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BreakableHoodie
enabled auto-merge (squash)
July 17, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two recap-page fixes found while grading the newly backfilled Vol 1 archive. #613:
is_returningchecked for a performance at any other archived event with no date predicate — playing Vol 3 retroactively made a band "returning" at Vol 1 (all 8 Vol 1 bands should be first-timers; the page showed 4/4). It now requires a chronologically earlier published-or-archived event, with an id tie-break for same-day editions, and counts published (not only archived) prior editions so fresh recaps don't miscount. #614: roster-only historical archives (Vols 1–14: no venue/time data) rendered three flavours of we-don't-know noise — "Venues: 0" tile, "TBD–TBD" time spans, and an "Unscheduled" group heading. Per the #608 omit-zero rule: the tile is omitted (grid drops to 4 columns — no dangling cell), empty time ranges render nothing, and the lone group is headed "Lineup"; partially-scheduled events keep "Unscheduled" where it's genuinely accurate.Closes #613
Closes #614
What changed
functions/api/events/[id]/recap.jsis_returningpredicate:(e2.is_published = 1 OR e2.status = 'archived') AND (e2.date < ? OR (e2.date = ? AND e2.id < ?)); redundantevent_id != ?kept as cheap defense; rationale commentedfunctions/api/events/__tests__/recap.test.jsfrontend/src/pages/EventRecapPage.jsxhasVenueDatafrom backendstats.venue_count(single source of truth); tile omission + conditional grid; guarded the one unguarded time-range site; Lineup/Unscheduled distinction commentedfrontend/src/pages/__tests__/EventRecapPage.test.jsxDeliberately left alone: per-band inline "Unscheduled" metadata text (issue scoped to the group heading);
formatTimeRangeutil (recap builds inline strings — guarded at the one call site instead).Security / correctness notes
None — public read-only endpoint + display logic. The recap response shape is unchanged.
Verification
validate:openapi: n/a — response shape unchangedBuilt by Sonny · Reviewed by Theo · 🤖 Claude Code