feat: move roster card icons below the text row#612
Merged
Conversation
BreakableHoodie
added
enhancement
6 tasks
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BreakableHoodie
enabled auto-merge (squash)
July 17, 2026 00:53
A long band name truncated against the right-aligned icon cluster. The icons now sit on their own row under the name/meta block (aligned with the text column), so the name gets the full card width and the card grows vertically instead — per Dre. Cards without links keep their original height. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BreakableHoodie
force-pushed
the
feat/roster-icons-below-text
branch
from
July 17, 2026 08:48
1ad153c to
33813ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #609 (merged) from Dre's review: a long band name truncated against the right-aligned icon cluster ("THE TIME TRAVEL…"). The icon row now sits below the name/meta block, aligned with the text column — the name gets the full card width and the card grows vertically instead. Cards without links keep their original height. Verified with a seeded worst case ("The Time Travelling Garbage Collectors" + 4 icons) in both dark and light themes; screenshots shared with Dre in-session.
Refs #607.
What changed
frontend/src/pages/ArtistsPage.jsxpl-[68px]aligns icon glyphs with the text column: 64px photo + 16px gap − 12px hit-area inset); name column no longer competes for widthSecurity / correctness notes
None — layout-only change; hrefs, sanitization, metrics, and aria-labels unchanged.
Verification
validate:openapi: n/aBuilt by Theo · Reviewed by Theo · 🤖 Claude Code