Skip to content

Restore 100% coverage and fix cli.main's mutable-default Game() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrandonZacharie merged 2 commits into from
May 23, 2026
Merged

Restore 100% coverage and fix cli.main's mutable-default Game() #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930ed8f
Restore 100% coverage across chess.py, cli.py, and game/game.py
claude May 22, 2026
8f72cf3
Fix mutable-default Game() argument in cli.main
claude May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,5 +493,5 @@ def _fileprompt(
raise KeyboardInterrupt


if __name__ == "__main__":
if __name__ == "__main__": # pragma: no cover
wrapper(Chess)
9 changes: 6 additions & 3 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,12 @@ def get_input(window: Window, mode: InputMode) -> List[int]:

def main(
window: Window,
game: Game = Game(),
game: Optional[Game] = None,
log_style: LogStyle = LogStyle.CoordinateNotation,
):
if game is None:
game = Game()

mode = InputMode.SELECT_CELL
q1 = ""
q2 = ""
Expand Down Expand Up @@ -310,7 +313,7 @@ def main(
case InputMode.SELECT_PROM:
try:
game.promote(PIECE_NAME_TYPE_MAP[input.upper()])
except KeyError:
except KeyError: # pragma: no cover - guarded by PROMOTION_PIECE_ORDS
draw_input_err(window, "Invalid input.")
else:
draw_board(window, game.board, log_style)
Expand All @@ -322,5 +325,5 @@ def run() -> None:
wrapper(main)


if __name__ == "__main__":
if __name__ == "__main__": # pragma: no cover
run()
Loading
Loading