fix(terminal): enable copyOnSelect in xterm.js terminals - #263
Merged
Conversation
Without this option xterm.js does not copy selected text to the clipboard, making it impossible to copy terminal output. Co-authored-by: Mistaber Code <code@mistaber.ai>
There was a problem hiding this comment.
Pull request overview
Enables xterm.js “copy on select” behavior across the dashboard’s interactive terminal and read-only output panel so selected terminal text is immediately copied to the clipboard.
Changes:
- Set
copyOnSelect: truefor the interactive session terminal (Terminal.tsx). - Set
copyOnSelect: truefor the read-only output terminal (OutputPanel.tsx).
Verdict: READY TO MERGE
Counts: [CRITICAL] 0 · [IMPORTANT] 0 · [NIT] 0
Scope detected: platform
Highlights:
- (none)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dashboard/frontend/src/components/Terminal/Terminal.tsx | Enables copyOnSelect on the interactive xterm instance without altering the WS preflight/error-handling logic. |
| dashboard/frontend/src/components/BottomPanel/OutputPanel.tsx | Enables copyOnSelect on the read-only xterm instance used for displaying output entries. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyOnSelect: truetoTerminal.tsx(interactive terminal)copyOnSelect: truetoOutputPanel.tsx(read-only output panel)Root cause
xterm.js does not copy selected text to the clipboard by default. Without
copyOnSelect: true, text selection has no clipboard effect — users cannot copy terminal output.Test plan
Generated by Mistaber Code — Computational Halacha Encoding Agent