Skip to content

revert: undo unauthorized merge of YD 87:9 (PR #260) - #261

Merged
levi770 merged 3 commits into
mainfrom
revert/yd-87-9-unauthorized-merge
Jun 5, 2026
Merged

revert: undo unauthorized merge of YD 87:9 (PR #260)#261
levi770 merged 3 commits into
mainfrom
revert/yd-87-9-unauthorized-merge

Conversation

@levi770

@levi770 levi770 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

PR #260 was merged via gh pr merge without a human reviewer approving it on GitHub. The correct process requires explicit approval before merge. This revert enforces the encoding pipeline protocol.

What's next

After this revert is approved and merged, a new PR will be created from session/RNekhoda/yd_87-9 and submitted through the normal review process.

Risk

Zero — this is a clean git revert of a single squash commit. No conflicts, no data loss.

Generated by Mistaber Code — Computational Halacha Encoding Agent

Copilot AI review requested due to automatic review settings June 5, 2026 10:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Verdict: READY TO MERGE
Counts: [CRITICAL] 0 · [IMPORTANT] 0 · [NIT] 1
Scope detected: encoding-session
Highlights:

  • [NIT] mistaber/corpus/corpus-manifest.yaml roadmap entry for YD 87:9 is mislabeled as “rennet/queijo rules”.

Reverts the previously squash-merged YD 87:9 encoding (PR #260), restoring main back to the last explicitly approved state (YD 87:8) by removing the YD 87:9 corpus artifacts, DSL source, compiled ontology output, and associated vocabulary/schema changes.

Changes:

  • Removes YD 87:9 encoding source (dsl/corpus/.../seif_9.hll) and all archived seif_9 artifacts/tests/reports.
  • Rolls back generated ontology/vocabulary/schema additions introduced for YD 87:9 (food_category enum values + derived predicates).
  • Updates corpus-manifest.yaml to remove the seif_9 entry and adjusts aggregate progress counts accordingly.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/engine/test_tech_health_yd_87_9.py Removes the per-seif tech-health overlay tied to YD 87:9.
mistaber/ontology/meta.lp Rolls back generated enum/predicate registry entries added for chalav keivah.
mistaber/ontology/corpus/yd_87/seif_9.lp Deletes compiled LP output for YD 87:9 (revert of generated artifact).
mistaber/ontology/corpus/yd_87/base.lp Removes the chalav_keivah guard exclusions from mixture_has_chalav/1.
mistaber/dsl/vocabulary/base.yaml Removes auto-generated vocabulary entries (predicates + enum values) added for YD 87:9.
mistaber/dsl/schema/sorts.hll Removes the YD 87:9 food_category enum additions.
mistaber/dsl/corpus/yd_87/seif_9.hll Deletes the YD 87:9 DSL encoding source.
mistaber/dsl/corpus/yd_87/base.hll Reverts the mixture_has_chalav guard extension and its encoding note for YD 87:9.
mistaber/corpus/yoreh_deah/siman_87/seif_9/validation-report.md Removes archived validate-phase report for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/validation-report-review.md Removes archived review-phase validator report for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/test_yd_87_9.py Removes archived test suite for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/scenario_pos_87_9.hll Removes archived positive scenario for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/scenario_neg_87_9.hll Removes archived negative scenario for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/review-package.md Removes archived human review package for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/qa-set.yaml Removes archived QA set for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-report.md Removes archived encoding report for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-mapping.yaml Removes archived statement→rule mapping for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-decisions.yaml Removes archived encoding decisions for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-sources.yaml Removes archived source digest for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-report.md Removes archived corpus report for the reverted seif.
mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-chain.mermaid Removes archived source-chain diagram for the reverted seif.
mistaber/corpus/corpus-manifest.yaml Removes the YD 87:9 “complete” entry and updates progress totals/roadmap.

Comment thread mistaber/corpus/corpus-manifest.yaml Outdated
Copilot NIT on PR #261: roadmap entry mislabeled as "rennet/queijo rules".
SA YD 87:9 is chalav keivah (milk in abomasum); rennet/cheese rules are YD 87:10.

Co-authored-by: Mistaber Code <code@mistaber.ai>
@levi770

levi770 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Fixed Copilot NIT: updated next_targets topic for YD 87:9 from "rennet/queijo rules" to "chalav keivah, milk in abomasum (seif 9)". Commit 41c51fd.

@levi770

levi770 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@copilot review

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown

@copilot review

Reviewed commit 41c51fd. The next_targets topic for YD 87:9 is now correctly set to "chalav keivah, milk in abomasum (seif 9)". No further issues found — the NIT is resolved and the revert is clean.

Copilot stopped work on behalf of levi770 due to an error June 5, 2026 10:50
@levi770
levi770 merged commit 9dd3731 into main Jun 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants