revert: undo unauthorized merge of YD 87:9 (PR #260) - #261
Conversation
…sum)" This reverts commit 01395d5.
There was a problem hiding this comment.
Pull request overview
Verdict: READY TO MERGE
Counts: [CRITICAL] 0 · [IMPORTANT] 0 · [NIT] 1
Scope detected: encoding-session
Highlights:
- [NIT]
mistaber/corpus/corpus-manifest.yamlroadmap entry for YD 87:9 is mislabeled as “rennet/queijo rules”.
Reverts the previously squash-merged YD 87:9 encoding (PR #260), restoring main back to the last explicitly approved state (YD 87:8) by removing the YD 87:9 corpus artifacts, DSL source, compiled ontology output, and associated vocabulary/schema changes.
Changes:
- Removes YD 87:9 encoding source (
dsl/corpus/.../seif_9.hll) and all archived seif_9 artifacts/tests/reports. - Rolls back generated ontology/vocabulary/schema additions introduced for YD 87:9 (food_category enum values + derived predicates).
- Updates
corpus-manifest.yamlto remove the seif_9 entry and adjusts aggregate progress counts accordingly.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/engine/test_tech_health_yd_87_9.py | Removes the per-seif tech-health overlay tied to YD 87:9. |
| mistaber/ontology/meta.lp | Rolls back generated enum/predicate registry entries added for chalav keivah. |
| mistaber/ontology/corpus/yd_87/seif_9.lp | Deletes compiled LP output for YD 87:9 (revert of generated artifact). |
| mistaber/ontology/corpus/yd_87/base.lp | Removes the chalav_keivah guard exclusions from mixture_has_chalav/1. |
| mistaber/dsl/vocabulary/base.yaml | Removes auto-generated vocabulary entries (predicates + enum values) added for YD 87:9. |
| mistaber/dsl/schema/sorts.hll | Removes the YD 87:9 food_category enum additions. |
| mistaber/dsl/corpus/yd_87/seif_9.hll | Deletes the YD 87:9 DSL encoding source. |
| mistaber/dsl/corpus/yd_87/base.hll | Reverts the mixture_has_chalav guard extension and its encoding note for YD 87:9. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/validation-report.md | Removes archived validate-phase report for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/validation-report-review.md | Removes archived review-phase validator report for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/test_yd_87_9.py | Removes archived test suite for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/scenario_pos_87_9.hll | Removes archived positive scenario for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/tests/scenario_neg_87_9.hll | Removes archived negative scenario for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/review-package.md | Removes archived human review package for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/qa-set.yaml | Removes archived QA set for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-report.md | Removes archived encoding report for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-mapping.yaml | Removes archived statement→rule mapping for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/encoding-decisions.yaml | Removes archived encoding decisions for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-sources.yaml | Removes archived source digest for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-report.md | Removes archived corpus report for the reverted seif. |
| mistaber/corpus/yoreh_deah/siman_87/seif_9/corpus-chain.mermaid | Removes archived source-chain diagram for the reverted seif. |
| mistaber/corpus/corpus-manifest.yaml | Removes the YD 87:9 “complete” entry and updates progress totals/roadmap. |
Copilot NIT on PR #261: roadmap entry mislabeled as "rennet/queijo rules". SA YD 87:9 is chalav keivah (milk in abomasum); rennet/cheese rules are YD 87:10. Co-authored-by: Mistaber Code <code@mistaber.ai>
|
Fixed Copilot NIT: updated |
|
@copilot review |
Reviewed commit |
Summary
01395d55(PR feat(ontology): encode YD 87:9 — chalav keivah (milk in abomasum) #260) that was merged without explicit reviewer approvalmainto the state atb36de4b(YD 87:8, last approved encoding)session/RNekhoda/yd_87-9Why
PR #260 was merged via
gh pr mergewithout a human reviewer approving it on GitHub. The correct process requires explicit approval before merge. This revert enforces the encoding pipeline protocol.What's next
After this revert is approved and merged, a new PR will be created from
session/RNekhoda/yd_87-9and submitted through the normal review process.Risk
Zero — this is a clean
git revertof a single squash commit. No conflicts, no data loss.Generated by Mistaber Code — Computational Halacha Encoding Agent