Skip to content

feat: make mobile number mandatory in CreateCustomerDialog #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MostafaKadry merged 1 commit into from
Jul 22, 2026
Merged

feat: make mobile number mandatory in CreateCustomerDialog #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions POS/src/components/sale/CreateCustomerDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<!-- Mobile Number with Country Code Selector -->
<div>
<label class="block text-start text-sm font-medium text-gray-700 mb-2">
{{ __("Mobile Number") }}
{{ __("Mobile Number") }} <span class="text-red-500">*</span>
</label>
<div class="flex gap-2">
<!-- Country Code Dropdown -->
Expand Down Expand Up @@ -114,6 +114,7 @@
:placeholder="__('Enter phone number')"
class="flex-1 px-3 py-2 border border-gray-300 rounded-lg text-sm focus:outline-none focus:ring-2 focus:ring-blue-500 text-start"
@input="updateMobileNumber"
required
/>
</div>
</div>
Expand Down Expand Up @@ -254,7 +255,7 @@
updateCustomerResource.loading ||
checkingPermission
"
:disabled="!customerData.customer_name || !hasPermission"
:disabled="!customerData.customer_name || !phoneNumber || !hasPermission"
>
{{ isEditMode ? __("Save Changes") : __("Create Customer") }}
</Button>
Expand Down Expand Up @@ -645,6 +646,9 @@ const handleCreate = async () => {
if (!customerData.value.customer_name) {
return showError(__("Customer Name is required"));
}
if (!phoneNumber.value) {
return showError(__("Mobile Number is required"));
}
if (isEditMode.value) {
await updateCustomerResource.submit();
} else {
Expand Down
Loading