Skip to content

feat: enhance coupon validation and customer selection in CouponDialog #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamedAliSmk wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: enhance coupon validation and customer selection in CouponDialog #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion POS/src/components/sale/CouponDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ const couponResource = createResource({
makeParams() {
return {
coupon_code: couponCode.value,
customer: props.customer,
customer: props.customer || "",
company: props.company,
};
},
Expand Down Expand Up @@ -361,6 +361,12 @@ async function applyCoupon() {
return;
}

if (!props.customer) {
errorMessage.value = __("Please choose a customer");
showError(errorMessage.value);
return;
}

applying.value = true;
errorMessage.value = "";

Expand Down
5 changes: 4 additions & 1 deletion pos_next/api/offers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,11 @@ def get_active_coupons(customer: str, company: str) -> list[dict]:


@frappe.whitelist()
def validate_coupon(coupon_code: str, customer: str, company: str) -> dict:
def validate_coupon(coupon_code: str, company: str, customer: str | None = None) -> dict:
"""Validate a coupon code and return its details"""
if not customer:
return {"valid": False, "message": _("Please choose a customer")}

if not frappe.db.table_exists("POS Coupon"):
return {"valid": False, "message": _("Coupons are not enabled")}

Expand Down
Loading