fix: reconcile site UUID with config sync before config:import in suds:update - #5
Open
andycarlberg wants to merge 1 commit into
Open
Conversation
…s:update config:import fails when the target site's system.site.uuid diverges from config/sync/system.site.yml, which happens on any environment provisioned independently of the source database (e.g. a fresh install). suds:update now sets the site's UUID to match config sync before importing, mirroring how BLT handled this in its update/deploy flow. Fixes Bounteous-Inc#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suds:updatenow reconciles the target site'ssystem.site.uuidwith the value recorded in the config sync directory before runningconfig:import, mirroring how BLT handled this in its update/deploy flow.site:install) get their own UUID, which previously causedconfig:importto fail with a UUID mismatch.Test plan
UpdateCommandsTest) cover UUID reconciliation dispatch and the skip-when-unavailable case.UpdateCommandsIntegrationTest) assertconfig:set system.site uuiddispatches in the correct order.suds:update, and confirms it's reconciled back to match config sync.composer lint,composer analyze, and the full unit/integration/functional suites pass locally.Fixes #1