Optimisation -> no need to join on stock table since we only need ids… - #50
Open
renaudAmsellem wants to merge 1 commit into
Open
Optimisation -> no need to join on stock table since we only need ids…#50renaudAmsellem wants to merge 1 commit into
renaudAmsellem wants to merge 1 commit into
Conversation
… of locations by store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… of locations by store
It is useless to join on the stock table since we only need ids of locations by store in the priorization function.
In our site, we have 2.8 millions of rows in the stock table. The join takes ~0.7 second for each product in the quote. Which is way too long in a production environment before the order confirmation.
With this upgrade, it takes ~0.05 second.
Thanks for the plugin by the way. It works great ! We have ~90 locations with 20000 products in total and it's perfect !