Feat: Added role icons, and gave some care to forums. - #33
Open
LittleEngineer wants to merge 19 commits into
Open
Feat: Added role icons, and gave some care to forums.#33LittleEngineer wants to merge 19 commits into
LittleEngineer wants to merge 19 commits into
Conversation
Multiple components have been updated: * Twilight has been updated to version 17.1 which brings with it new components for both messages and modals. * User and message command validation now correctly allows mixed case and space characters. * VSCode extension has been updated to allow typings data to be downloaded from a different botloader bost.
…mmand permissions with the command builders.
Added validation to ensure forwarded messages originate from the same guild a message is being created within.
…ed common code for resolving interaction data to a common class of helper functions. Component code has also altered to remove multiple constructors except for on the Label component for convenience when using text input components.
Added a `setRequired` method for select menu components, and rectified workers crashing as a result of the premium button style missing (`todo!()`). Without this, VM workers would crash at random and require a full scheduler restart.
…or `ModalSubmitInteraction`
… reference in cargo.toml.
Contributor
|
There's been some changes to the repo, I've also added a changelog.md where you can attach the changelog you made in the unreleased section (feel free to reference this PR as well in the changelog) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the promised support for role icons. As well as some extra stuff for forums.
Features:
nullwhen editing the roleRegarding the public threads, I'm a bit unsure if it would be better to expose the full channel flags, even though only the
pinnedproperty exists on it. A possible downside of not exposing the full flags is that using the pin/unpin methods could wipe out any additional flags Discord may (or may not) decide to add in the future. Also, it appears trying to pin another post requires the old one to be unpinned. I'm not too sure on how to find which one the currently pinned thread is.Edit: I also updated the Cargo.toml file to reference your own branch of Twilight rather than mine, and updated the Cargo.lock file (a consequence of needing to resolve a merge conflict).