Feature/leaderboard - #52
Merged
Merged
Conversation
Added methods in GameServerManager to broadcast the leaderboard and retrieve leaderboard messages. Implemented handlePlayerDisconnect in GameManager to clean up pending requests and active games when a player disconnects, notifying opponents and updating player statuses accordingly. Updated removePlayer in GameServerManager to invoke this disconnect handler.
Broadcasts the leaderboard after user registration and adds a GET_LEADERBOARD action to the Action enum. MessageRouter now handles GET_LEADERBOARD requests, and minor code cleanup was performed in authentication and game response handling.
Refactored GameServerManager by removing duplicate and misplaced code in getAvailablePlayersMessage, improving method structure and readability.
Hazem-0
approved these changes
Jan 12, 2026
ZeiadT
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle player disconnects and add leaderboard broadcast to all users