implement MessageRouter and remove its logic from server, refactor Authentication Service update project architecture reformat all code files upgrade to java 25 for javafx usage later on - #34
Merged
Conversation
refactor Authentication Service update project architecture reformat all code files upgrade to java 25 for javafx usage later on
ZeiadT
requested review from
Hazem-0,
MahmoudRafaat,
SherifAshraf2020 and
tasneem-hakeem
December 30, 2025 08:30
Updated package structure and import statements in AuthenticationService.
SherifAshraf2020
previously approved these changes
Dec 30, 2025
MahmoudRafaat
previously approved these changes
Dec 30, 2025
…tor/messaging-protocol # Conflicts: # pom.xml # src/main/java/com/mycompany/tictactoeserver/datasource/model/ActivityPoint.java # src/main/java/com/mycompany/tictactoeserver/domain/services/statistics/ActivityService.java # src/main/java/com/mycompany/tictactoeserver/domain/utils/exception/ActiveSessionExistsException.java # src/main/java/com/mycompany/tictactoeserver/domain/utils/exception/ActivityNotFoundException.java # src/main/java/com/mycompany/tictactoeserver/domain/utils/exception/DataAccessException.java # src/main/java/com/mycompany/tictactoeserver/domain/utils/exception/ExceptionHandlerMiddleware.java # src/main/resources/database/database.sql
refactor Authentication Service update project architecture reformat all code files upgrade to java 25 for javafx usage later on
…o refactor/messaging-protocol # Conflicts: # pom.xml # src/main/java/com/mycompany/tictactoeserver/datasource/model/ActivityPoint.java # src/main/resources/database/database.sql
ZeiadT
dismissed stale reviews from MahmoudRafaat and SherifAshraf2020
via
December 30, 2025 18:23
25c428a
refactor Authentication Service update project architecture reformat all code files upgrade to java 25 for javafx usage later on
Hazem-0
approved these changes
Dec 30, 2025
SherifAshraf2020
approved these changes
Dec 30, 2025
MahmoudRafaat
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.