suggestion count fix#91
Merged
Merged
Conversation
ProcessOptimizer's default ask strategy (stbr_fill) routes multi-point asks on a fitted model through stbr_scipy() — 20 SciPy minimisations over the one-hot-transformed space. On categorical-heavy experiments (e.g. 31 transformed dims) a count-2 request ran ~30 min (synchronous hang / worker timeout). The constrained branch already used cl_min; the unconstrained branch fell through to the slow default. Always use cl_min: count 1 is unchanged (strategy is ignored for a single point), multi-point is fast and categorical-safe. Adds a watchdog-guarded regression test and ADR 0004. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…thin a budget Re-introduce stbr_fill space-filling for the extra points of an unconstrained batch, but only when affordable: a deterministic cost estimate (_estimate_stbr_seconds) — dominated by categorical one-hot dimensions — must fit STBR_TIME_BUDGET_SECONDS (default 10s, calibrated on the CPython venv). Otherwise fall back to cl_min. The estimate is a pure function of the space and batch size, so the chosen strategy (and the suggestions) stay reproducible across machines. Updates ADR 0004 and adds gate tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.