Repository navigation
Pin gpui-mobile with the #30 review fixes; pass uiMode on config changes - #77
Merged
Merged
Conversation
gpui-mobile main e12e14d carries the night-mode review fixes and the platform lock fix (fork #13, #14). host::configuration_changed now takes newConfig.uiMode, so LabActivity passes it through nativeConfigurationChanged. MOBILE_PATCHES.md and the gpui-mobile skill describe the new call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the gpui-mobile pin to fork main
e12e14d, which now has:open_window/reinit_window, read from the host Activity's Resources, andwindow_appearanceanswered from the cached value;host::configuration_changednow takesnewConfig.uiMode, soLabActivity.onConfigurationChangedpassesconfig.uiModethroughnativeConfigurationChanged. MOBILE_PATCHES.md and the gpui-mobile skill are updated to match.On the phone with the same code (a local test merge): cold start in dark, a live toggle to light, resume after a toggle, and app-local dark on a light system all show the right appearance on Diagnostics. The pinned merge itself was checked with
cargo clippy --target aarch64-linux-android. CI builds the APK.🤖 Generated with Claude Code