Skip to content

Restructuring headers and updating makevars in R-package#4

Open
Blunde1 wants to merge 5 commits into
masterfrom
Restructuring-Header-Files
Open

Restructuring headers and updating makevars in R-package#4
Blunde1 wants to merge 5 commits into
masterfrom
Restructuring-Header-Files

Conversation

@Blunde1

@Blunde1 Blunde1 commented Oct 1, 2019

Copy link
Copy Markdown
Owner

Header files are base C++, which distributions in R, Py, Java, ... will read from. They should be located under root, not under R-package

@Blunde1

Blunde1 commented Oct 2, 2019

Copy link
Copy Markdown
Owner Author

Cannot find header files during installation from GitHub. Asked question https://stackoverflow.com/q/58189830/7456798 on stackoverflow.

@Blunde1

Blunde1 commented Oct 2, 2019

Copy link
Copy Markdown
Owner Author

Works with travis: dependent upon

before_install:
 - cp -r inst/include R-package/include
 - cd R-package

and modifying Makevars accordingly.

Will still fail with devtools::install_github

Do not merge pull-request before functional with above function or on CRAN (or some other easy way to install).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant