Successful Comma 4 Boot#132
Open
JBassett wants to merge 13 commits into
Open
Conversation
The BluePilot custom home layout (`home_bp.py`) was missing the `AlertsPill` used to display and access offroad alerts. Updated the layout to match the stock Mici layout's `set_callbacks` signature, now accepting `on_alerts`, `alert_count_callback`, and `max_severity_callback`. Instantiated the `AlertsPill` component and positioned it just below the settings gear icon so offroad alerts remain reachable. Added hit-testing (`_point_in_alerts`) and click routing to ensure tapping the pill successfully opens the alerts pane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR started by getting the Comma 4 booting, then turned into removing the custom BP branding on the settings. It was non functional and this MR reduces our touch points into sunnypilot which should help make pulling upstream changes easier.